Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mise exec tuist generate in documentation #7108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HossamYoussof
Copy link

@HossamYoussof HossamYoussof commented Nov 27, 2024

Short description πŸ“

mise changed exce command from mise x to mise exec -- or mise x --, I selected mise exec -- for readability

Contributor checklist βœ…

  • The code has been linted using run mise run lint-fix
  • The change is tested via unit testing or acceptance testing, or both
  • The title of the PR is formulated in a way that is usable as a changelog entry
  • In case the PR introduces changes that affect users, the documentation has been updated

Reviewer checklist βœ…

  • The code architecture and patterns are consistent with the rest of the codebase
  • Reviewer has checked that, if needed, the PR includes the label changelog:added, changelog:fixed, or changelog:changed, and the title is usable as a changelog entry

Copy link

tuist bot commented Nov 27, 2024

πŸ› οΈ Tuist Run Report πŸ› οΈ

Tuist Tests πŸ§ͺ

Command Status Cache hit rate Tests Skipped Ran Commit
test TuistApp -- CODE_SIGN_IDENTITY= CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO βœ… 100 % 1 0 1 61f4e7f9f
test TuistAutomationAcceptanceTests βœ… 100 % 1 0 1 61f4e7f9f
test TuistDependenciesAcceptanceTests βœ… 100 % 1 0 1 61f4e7f9f
test TuistGeneratorAcceptanceTests βœ… 100 % 1 0 1 61f4e7f9f
test TuistKitAcceptanceTests ❌ 100 % 1 0 1 61f4e7f9f
test TuistUnitTests βœ… 100 % 23 0 23 61f4e7f9f

Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I believe changes should be limited to the docs files in en – otherwise, our localization platform might be confused. We can merge afterwards πŸ™‚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants