CLDR-18056 skintone with facing right #4213
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18056
Adds skintones to the right-facing emoji. These are emoji that add joiner+right_facing_arrow to point to the right. It also fixes 2 other problems: the "facing right" was not added to annotations, and in the name it didn't have a colon before it like other modifiers.
Example 1, with skin tones
becomes
Example 2, without skin tones
becomes
Reviewer:
tools/cldr-code/src/main/java/org/unicode/cldr/util/Annotations.java
if (code.contains(EmojiConstants.JOINER_STRING)) {
got simpler, because we now just remove the arrow fromcode
, and add it torem
. That allows it to fall through properly toprivate Annotations getBasePlusRemainder(
, which handles the code.if (mod == BLACK_RIGHTWARDS_ARROW.codePointAt(0)) {
and just setting a flagtools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestAnnotations.java
Restored TestUniqueness. That tests for exactly this kind of failure, and shouldn't have been removed unless a replacement was ready.
Added testCompleteness, that all emoji have English annotations.
Added testRightFacing, which has specific test cases for this problem.
This PR completes the ticket.
ALLOW_MANY_COMMITS=true