Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-18129 Investigate and fix (where necessary) invalid codes #4215

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

macchiati
Copy link
Member

CLDR-18129

common/dtd/ldml.dtd

  • for @match language@type, use nlocale (locales for names)

common/dtd/ldmlSupplemental.dtd

  • all @match changes:
  • languageAlias@type, use bc47-wellformed (locales for names), and list allowed ill-formed values
  • likelySubtag@from&to, use xlocale (which allows for compatibility cases like "iw"
  • pluralRules@locales, use xlocale but also allow "sh"

common/main/en.xml
common/main/fi.xml
common/main/la.xml
common/main/nl.xml
common/supplemental/supplementalData.xml
common/supplemental/supplementalMetadata.xml

  • Tighten down the test to avoid deprecated / predominant-encompassed languages.
  • Add XLocaleMatchValue, NLocaleMatchValue to allow for special cases

tools/cldr-code/src/main/java/org/unicode/cldr/util/MatchValue.java

  • tighten up validity/locale to disallow deprecated
  • allow for setting the status for each field separately
  • provide for subclassing to extend the language check

tools/cldr-code/src/main/java/org/unicode/cldr/util/SupplementalDataInfo.java
tools/cldr-code/src/main/java/org/unicode/cldr/util/Validity.java

  • Allow for testing validity against past versions

tools/cldr-code/src/main/java/org/unicode/cldr/util/UnitConverter.java

  • clean up some code that didn't allow for old versions

tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestAttributeValues.java

  • Enhance testing to print (warnln) details of which items caused failures.

tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestBasic.java

  • Add compatibility test for bcp47 to ensure that identifiers never disappear

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant