Rebuild API as TS #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file is far too large and it will likely break your IDE if you try to view differences. Working in it is laggy for me as well D;
TSC was throwing an error about these via this code: `.api/apis/edenai/types.ts` ``` export type TextAnonymizationCreateResponse200 = FromSchema< (typeof schemas.TextAnonymizationCreate.response)['200'] >; ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks out v1.05 before the fern changes were added, those may need to be removed or reverted.
This creates the API utilizing TS and then includes the TS as part of the TSC build pipeline.
When running TSC I was getting a type error from the api.
TSC was throwing an error about these via this code:
.api/apis/edenai/types.tsMy IDE was not displaying these issues until I switched the 5.1.6 TS engine from VSCode to the project's save version (5.1.6), then they started highlighting in the IDE.
Oddly the types file was affected by the definitions from the schemas file.
I'm not sure if this will fix any issues, but it's worth a try. Maybe this is why the typing wasn't working before? I wonder if it's an issue in the Open API spec or something that needs to be addressed in the api library?¿ 🤔
PS: We should probably rimraf the build directory [dist] before we build it out every time, so we guarantee a clean slate.
Edit: it doesn't seem that the
.apifolder is being included into the build as I would expect 😕 Maybe this is because it's seen as an NPM package. I wonder if the consumer knows to include that or how it resolves it. So maybe it does need to be common JS instead, or the consumer needs to explicitly add it to it's TS Config build pipeline.