Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update React to v18 & AntD to v5 #1376

Merged
merged 28 commits into from
Oct 29, 2024
Merged

Update React to v18 & AntD to v5 #1376

merged 28 commits into from
Oct 29, 2024

Conversation

piotrpospiech
Copy link
Collaborator

@piotrpospiech piotrpospiech commented Oct 28, 2024 •
edited
Loading

Core pull request to update React Testing Library and React in uniforms packages. It will add official support for React v18 as it wasn't backed with tests #1130.

Important changes

  • Updated React to v18 in all packages and reproductions directory
  • Updated @testing-library/react to version that supports React 18 (v14.x)
  • Updated tests after updating React and React Testing Library
    • Fixed tests (addressing breaking changes)
    • Fixed lint and TS errors
  • Migrated from npm to pnpm (forced by issue with resolving different package versions in monorepo)
    • Changed package-lock.json to pnpm-lock.yaml
    • Configured pnpm-workspace.yaml
    • Updated scripts and packageManager in package.json
    • Updated other uses of npm (CI, documentation, etc.)
  • Updated Github Actions workflows
  • Updated .gitignore, .eslintignore, etc.

Future changes

  • Fix warnings during test run
  • Fix linting in the reproductions directory. It has been disabled temporary
  • Add changelog with information about new version of AntD

piotrpospiech and others added 20 commits October 24, 2024 09:21
@piotrpospiech
updated react to v18
e6e3ca5
@piotrpospiech
updated testing library to 13.4.0
a3098cf
@piotrpospiech
updated testing library to v14.3.1
ca38213
@piotrpospiech
fixing tests - wip
341d69d
@piotrpospiech
fixed submit in forEach test
5ba9be0
@kestarumper
Replace act with waitFor ValidatedForm
eb815df
@piotrpospiech
removed regexes from *ByRole
34e4e06
@kestarumper
Replace act with waitFor AutoForm BaseForm
c8cfadd
@piotrpospiech
removed react & react-dom from package.json
492fb00
@piotrpospiech
removed comment
2c01513
@kestarumper
Update react to 18 unstyled semantic bootstrap4 bootstrap5
8420ee6
@piotrpospiech
updated validation flow test
f1f087e
@piotrpospiech
migrated from npm to pnpm
565f78f
@piotrpospiech
updated scripts
7eb4d3e
@piotrpospiech
added @types/react to uniforms core package
4947bf9
@piotrpospiech
removed import from uniforms-bootstrap4
8f07531
@piotrpospiech
disabled AntD and MUI tests
d7ad699
@piotrpospiech
fixed dependencies and disabled some eslint rules temporary
b104cc9
@piotrpospiech
updated react for mui
d0fe9b5
@piotrpospiech
enabled and fixed MUI tests
dbd46be
@github-actions github-actions bot added Area: Infra Affects the repository itself (e.g., CI, dependencies) Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages Area: Bridge Affects some of the bridge packages Theme: AntD Affects the uniforms-antd package Theme: Bootstrap 4 Affects the uniforms-bootstrap4 package Theme: Bootstrap 5 Affects the uniforms-bootstrap5 package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package Theme: Unstyled Affects the uniforms-unstyled package labels Oct 28, 2024
@github-actions github-actions bot added the Bridge: SimpleSchema (v2) Affects the uniforms-bridge-simple-schema-2 package label Oct 28, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.46%. Comparing base (2b680f2) to head (36edcbe).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1376   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files         175      175           
  Lines        2869     2869           
  Branches      775      775           
=======================================
  Hits         2739     2739           
  Misses         59       59           
  Partials       71       71

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the Area: Docs Affects the documentation or reproductions seed label Oct 28, 2024
@piotrpospiech piotrpospiech added this to the v4.0 milestone Oct 28, 2024
@piotrpospiech piotrpospiech self-assigned this Oct 28, 2024
@piotrpospiech piotrpospiech marked this pull request as ready for review October 28, 2024 15:30
@piotrpospiech piotrpospiech mentioned this pull request Oct 28, 2024
Closed
@piotrpospiech piotrpospiech mentioned this pull request Oct 28, 2024
Closed
@piotrpospiech piotrpospiech changed the title Update React to v18 Update React to v18 & AntD to v5 Oct 28, 2024
kestarumper
kestarumper approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@kestarumper kestarumper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Titanic work done!

packages/uniforms-antd/src/NumField.tsx Show resolved Hide resolved
@piotrpospiech piotrpospiech merged commit 36eb052 into master Oct 29, 2024
6 checks passed
@piotrpospiech piotrpospiech deleted the update-react branch October 29, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zendranm zendranm zendranm approved these changes

@zaxovaiko zaxovaiko zaxovaiko approved these changes

@Monteth Monteth Monteth approved these changes

@kestarumper kestarumper kestarumper approved these changes

@wadamek65 wadamek65 Awaiting requested review from wadamek65 wadamek65 is a code owner

@ErnestTeluk ErnestTeluk Awaiting requested review from ErnestTeluk

Assignees

@piotrpospiech piotrpospiech

Labels
Area: Bridge Affects some of the bridge packages Area: Core Affects the uniforms package Area: Docs Affects the documentation or reproductions seed Area: Infra Affects the repository itself (e.g., CI, dependencies) Area: Theme Affects some of the theme packages Bridge: SimpleSchema (v2) Affects the uniforms-bridge-simple-schema-2 package Theme: AntD Affects the uniforms-antd package Theme: Bootstrap 4 Affects the uniforms-bootstrap4 package Theme: Bootstrap 5 Affects the uniforms-bootstrap5 package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package Theme: Unstyled Affects the uniforms-unstyled package
Projects
Open Source
Archived in project
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.

React 18 Support v5 of AntD
5 participants
@piotrpospiech @kestarumper @Monteth @zaxovaiko @zendranm