Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node coverage stats deletions #336

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Node coverage stats deletions #336

merged 2 commits into from
Sep 14, 2023

Conversation

shreyasun
Copy link
Collaborator

Fixes #327

adamnovak
adamnovak approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@adamnovak adamnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code to deduct for deletions could be refactored out into one function instead of 3 copies, but I think this is fine and going to work.

@adamnovak adamnovak merged commit 5e77fd9 into master Sep 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamnovak adamnovak adamnovak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Account for deletions in per-node coverage
2 participants
@shreyasun @adamnovak