Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition: expand role allowances for fieldset element #442

Draft
wants to merge 13 commits into
base: gh-pages
Choose a base branch
from

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Dec 21, 2022

closes #400

Updates allowances for the toolbar, menubar, menu, listbox, tablist, article, dialog and region roles to be used on the fieldset element.


Preview | Diff

closes #400

Updates allowances for the toolbar, menubar, menu, listbox, tablist, article, dialog and region roles to be used on the fieldset element.
@scottaohara scottaohara added Allowed roles Pertaining to the allowed roles of HTML elements needs implementation commitment Cannot merge into spec until implementations in conformance checkers has been confirmed. labels Dec 21, 2022
@scottaohara scottaohara marked this pull request as draft December 21, 2022 20:07
index.html Outdated Show resolved Hide resolved
@smhigley
Copy link

I like the role expansion. I think some of these other roles might also merit being allowed on fieldset:

  • application
  • banner
  • complementary
  • contentinfo
  • document
  • feed
  • list
  • listitem
  • main

@stevefaulkner
Copy link
Collaborator

@scottaohara @smhigley Am not understanding the use cases for making control grouping/labelling semantic elements into non control grouping.

Copy link
Collaborator

@stevefaulkner stevefaulkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until a discussion around addition of article has occurred please do not commit

@scottaohara
Copy link
Member Author

@stevefaulkner happy to talk about this when i get back to work in the new year. but quickly, the intent here is to stop disallowing the use of roles on elements where it's actually preventing the ability for some developers to rectify poor markup.

An alternate proposal i have also been working on is to more clearly indicate what roles MUST NOT be used by developers, vs those which belong more in the SHOULD NOT category (e.g., use the appropriate HTML element instead). article, and maybe some of the roles that Sarah mentioned, could very well belong to the 'should not' category... more on that when we speak though.

@stevefaulkner
Copy link
Collaborator

stevefaulkner commented Dec 28, 2022 via email

@scottaohara
Copy link
Member Author

noting that steve and i talked this over. going to move forward with the further clarification proposal i had mentioned in my last comment, so this PR will be adjusted.

incorporates feedback from steve and sarah.  includes language "the following roles are allowed, but are NOT RECOMMENDED" to introduce new allowed roles which _can_ work depending on what's been built, but there are probably better ways to do this.  This wording is also used in #446, and allows for us to indicate these changes per element, without having to restructure the entire table (as this can be the end goal, rather than trying to get all allowed roles for all elements updated at once).
@scottaohara scottaohara added the needs changelog entry once 2 implementations land, we can merge and note it in our changelog. label Feb 6, 2023
index.html Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Allowed roles Pertaining to the allowed roles of HTML elements needs changelog entry once 2 implementations land, we can merge and note it in our changelog. needs implementation commitment Cannot merge into spec until implementations in conformance checkers has been confirmed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding menubar and toolbar to fieldset
4 participants