Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CompositionEvent.init take a Window rather than WindowProxy #379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamierocks
Copy link

This matches all other initUIEvent methods, the existing parameter explanations of the spec, Firefox, and Chromium.

Although WebKit uses WindowProxy, it's worth noting that it uses it in place of Window for other UIEvents too. (they have a FIXME for KeyboardEvent for example)

The following tasks have been completed:

  • Confirmed there are no ReSpec/BikeShed errors or warnings.
  • Modified Web platform tests (link to pull request)

Implementation commitment:

This matches all other initUIEvent methods, the existing parameter
explanations of the spec, Firefox, and Chromium.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant