Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS - payments onboarding] Workaround for the visual glitch when SelectPaymentMethodFragment was visible #12991

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Nov 25, 2024

Closes: #12975

Description

The PR makes UI of SelectPaymentMethodFragment invisible after navigation to the next step as during onboarding project the WooPOSCardReader activity is not invisible anymore and as we open the dialog, even if it's pop-uped from the back stack, the UI was still visible

Steps to reproduce

  • More -> POS
  • Add an item
  • Start collecting payments
  • Notice that there is visible fragment on the background of the reader connection dialog

The tests that have been performed

The one in the steps to repro

Images/gif

11-25--10-47.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

… visible under the connection dialog in the POS payment flow
@kidinov kidinov added the feature: point of sale POS project label Nov 25, 2024
@kidinov kidinov added this to the 21.3 milestone Nov 25, 2024
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commite2bfefd
Direct Downloadwoocommerce-wear-prototype-build-pr12991-e2bfefd.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commite2bfefd
Direct Downloadwoocommerce-prototype-build-pr12991-e2bfefd.apk

@kidinov kidinov removed the request for review from samiuelson November 26, 2024 10:48
@kidinov kidinov changed the base branch from trunk to release/21.2 November 26, 2024 10:49
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR contains changes to RELEASE-NOTES.txt.
Note that these changes won't affect the final version of the release notes as this version is in code freeze.
Please, get in touch with a release manager if you want to update the final release notes.

Generated by 🚫 Danger

@kidinov kidinov marked this pull request as draft November 26, 2024 10:50
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.75%. Comparing base (d3bda7b) to head (e2bfefd).
Report is 9 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #12991   +/-   ##
=========================================
  Coverage     39.75%   39.75%           
  Complexity     5992     5992           
=========================================
  Files          1268     1268           
  Lines         73262    73262           
  Branches      10046    10046           
=========================================
  Hits          29124    29124           
  Misses        41571    41571           
  Partials       2567     2567           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kidinov kidinov changed the base branch from release/21.2 to trunk November 26, 2024 10:52
@kidinov kidinov closed this Nov 26, 2024
@kidinov kidinov deleted the 12975-woo-pos---payments-onboarding-there-is-a-visible-loading-indicator-right-before-connection-dialog-appears-in-the-payment-flow branch November 27, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants