Fix placement of the .active class for dropdown items & remove dropdown when item has no visible children #530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #431 (misplaced
.active
class).Fixes dropdown markup on items without children (reported in #517 (comment)).
Changes proposed in this Pull Request:
$is_dropdown
,$is_dropdown_item
,$is_active
. They indicate whether a menu item is a dropdown, a dropdown item and whether the menu item is active..active
class from the li-element and add it to the a-element if the item is a dropdown item. (https://getbootstrap.com/docs/4.6/components/dropdowns/#active)Proposed changelog entry for your changes:
Fix misplaced .active class
Remove dropdown markup on items without visible children