new proposal types #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openmls/src/messages/proposals_in.rs
Outdated
| @@ -70,6 +70,8 @@ pub enum ProposalIn { | |||
| // was moved to `draft-ietf-mls-extensions-00`. | |||
| #[tls_codec(discriminant = 8)] | |||
| AppAck(AppAckProposal), | |||
| DeviceAdd(AddProposalIn), | |||
| DeviceRemoveProposal(RemoveProposal), | |||
There was a problem hiding this comment.
Any reason this one isn't just DeviceRemove for consistency?
There was a problem hiding this comment.
No reason... this should be DeviceRemove 🙂
|
Was the thinking that the additional metadata would go into a separate PR? |
This was the minimal thing and I forgot about the metadata. That's a small addition that I'll do. It just requires a new proposal struct with a some opaque bytes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new proposal types for add and remove.