Skip to content

Commit

Permalink
fix: add six.text_type to the check of command_with_args (#4290)
Browse files Browse the repository at this point in the history
- the type of 'provider' is `unicode` in python2 env,
  use 'six.text_type' for compatibility check
- add E203 to flake8.ignore as per
  https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#slices

Signed-off-by: Xiangce Liu <[email protected]>
  • Loading branch information
xiangce authored Nov 28, 2024
1 parent ce06652 commit 48ed453
Show file tree
Hide file tree
Showing 3 changed files with 355 additions and 111 deletions.
2 changes: 1 addition & 1 deletion .flake8
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[flake8]
ignore = E501,E126,E127,E128,E722,E741,W503,W504
ignore = E203,E501,E126,E127,E128,E722,E741,W503,W504
exclude = insights/contrib,bin,docs,include,lib,lib64,.git,.collections.py,insights/parsers/tests/lvm_test_data.py,insights/client/apps/ansible/playbook_verifier/contrib,insights/tools/coverage.py
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ repos:
# inherit from original .flake8
# add news:
# - W503 black conflicts with "line break before operator" rule
'--ignore=E501,E126,E127,E128,E722,E741,W503,W504']
'--ignore=E203,E501,E126,E127,E128,E722,E741,W503,W504']

- repo: https://github.com/gitleaks/gitleaks
rev: v8.21.2
Expand Down
Loading

0 comments on commit 48ed453

Please sign in to comment.