Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary (and incorrect) Zygote rule for PDBijector #286

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Remove unnecessary (and incorrect) Zygote rule for PDBijector #286

merged 5 commits into from
Aug 16, 2023

Conversation

yebai
Copy link
Member

@yebai yebai commented Aug 16, 2023 •
edited
Loading

@yebai yebai requested a review from devmotion August 16, 2023 17:10
@yebai yebai changed the title Fix bug in Zygote for PDBijector Remove unnecessary (and incorrect) Zygote rule for PDBijector Aug 16, 2023
@devmotion
Copy link
Member

Long-term ideally we would not define Zygote-specific rules anymore but mainly/only ChainRules definitions.

To this PR: Doesn't this require FluxML/Zygote.jl#1444? If so, I guess we should add/update the lower bound for Zygote.

@yebai
Copy link
Member Author

yebai commented Aug 16, 2023

To this PR: Doesn't this require FluxML/Zygote.jl#1444? If so, I guess we should add/update the lower bound for Zygote.

Fixed.

@yebai yebai merged commit 9419d4f into master Aug 16, 2023
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the yebai-patch-1 branch August 16, 2023 18:56
torfjelde
torfjelde reviewed Aug 17, 2023
View reviewed changes
Project.toml
@@ -30,6 +30,9 @@ ReverseDiff = "37e2e3b7-166d-5795-8a7a-e32c996b4267"
Tracker = "9f7883ad-71c0-57eb-9f7f-b5c9e6d3789c"
Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"

[extras]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is only Zygote added here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter for our tests because we have test/Project.toml. But Pkg requires it, otherwise it's not possible to add a compat entry for a weak dependency.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just remove the test/Project.toml if possible (IIRC it helped with some dependency incompatibilities a while ago but maybe that's not a problem anymore).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torfjelde torfjelde torfjelde left review comments

@devmotion devmotion Awaiting requested review from devmotion

@harisorgn harisorgn Awaiting requested review from harisorgn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yebai @devmotion @torfjelde