Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary (and incorrect) Zygote rule for PDBijector #286

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Remove unnecessary (and incorrect) Zygote rule for PDBijector #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a973f4
Update BijectorsZygoteExt.jl
yebai Aug 16, 2023
c05a555
Update BijectorsZygoteExt.jl
yebai Aug 16, 2023
e6ec70d
Update Project.toml
yebai Aug 16, 2023
e603bdf
Update Project.toml
yebai Aug 16, 2023
5902fd9
Update Project.toml
yebai Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "Bijectors"
uuid = "76274a88-744f-5084-9051-94815aaf08c4"
version = "0.13.5"
version = "0.13.6"

[deps]
ArgCheck = "dce04be8-c92d-5529-be00-80e4d2c0e197"
Expand Down Expand Up @@ -30,6 +30,9 @@ ReverseDiff = "37e2e3b7-166d-5795-8a7a-e32c996b4267"
Tracker = "9f7883ad-71c0-57eb-9f7f-b5c9e6d3789c"
Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"

[extras]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is only Zygote added here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter for our tests because we have test/Project.toml. But Pkg requires it, otherwise it's not possible to add a compat entry for a weak dependency.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just remove the test/Project.toml if possible (IIRC it helped with some dependency incompatibilities a while ago but maybe that's not a problem anymore).

Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"

[extensions]
BijectorsDistributionsADExt = "DistributionsAD"
BijectorsForwardDiffExt = "ForwardDiff"
Expand All @@ -42,6 +45,7 @@ BijectorsZygoteExt = "Zygote"
ArgCheck = "1, 2"
ChainRules = "1"
ChainRulesCore = "0.10.11, 1"
Zygote = "0.6.63"
ChangesOfVariables = "0.1"
Compat = "3, 4"
Distributions = "0.25.33"
Expand Down
3 changes: 0 additions & 3 deletions ext/BijectorsZygoteExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,9 +224,6 @@ end
end
return pullback(_maximum, d)
end
@adjoint function lower_triangular(A::AbstractMatrix)
return lower_triangular(A), Δ -> (lower_triangular(Δ),)
end
@adjoint function pd_from_lower(X::AbstractMatrix)
return LowerTriangular(X) * LowerTriangular(X)',
Δ -> begin
Expand Down
Loading