Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FED-1569 Prepare for null safety: fix lints and implicit casts #366

Merged
merged 31 commits into from
Aug 22, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
e452d16
Upgrade lints to workiva_analysis_options v2.recommended
greglittlefield-wf Aug 9, 2023
1446d0b
dart fix --apply --code=unnecessary_new
greglittlefield-wf Aug 9, 2023
1e322c2
dart fix --apply --code=unnecessary_const
greglittlefield-wf Aug 9, 2023
acc03f1
dart fix --apply --code=prefer_single_quotes
greglittlefield-wf Aug 9, 2023
5d2793d
dart fix --apply --code=deprecated_colon_for_default_value
greglittlefield-wf Aug 9, 2023
d19f23d
dart fix --apply --code=annotate_overrides
greglittlefield-wf Aug 9, 2023
bcad3b1
dart fix --apply --code=prefer_final_in_for_each
greglittlefield-wf Aug 9, 2023
8d1a829
dart fix --apply --code=omit_local_variable_types,prefer_final_locals
greglittlefield-wf Aug 9, 2023
46a38d2
Fix missing inferred generics
greglittlefield-wf Aug 9, 2023
17b30cc
dart fix --apply --code=use_function_type_syntax_for_parameters,pref…
greglittlefield-wf Aug 9, 2023
b79d3eb
Fix more typedefs
greglittlefield-wf Aug 9, 2023
6490a9c
dart fix --apply --code=unnecessary_this
greglittlefield-wf Aug 9, 2023
1b5f972
dart fix --apply --code=unnecessary_brace_in_string_interps
greglittlefield-wf Aug 9, 2023
2948941
dart fix --apply --code=unnecessary_parenthesis
greglittlefield-wf Aug 9, 2023
911c914
Disable some more lints
greglittlefield-wf Aug 9, 2023
70429ac
Remove some unnecessary function parameter types, link to linter issue
greglittlefield-wf Aug 11, 2023
ae1914e
Ignore lints that could change behavior or break public API if fixed
greglittlefield-wf Aug 9, 2023
8b83f89
dart fix --apply --code=unused_import
greglittlefield-wf Aug 9, 2023
ae87897
dart fix --apply --code=unnecessary_import
greglittlefield-wf Aug 9, 2023
82c5d9e
Fix miscellaneous remaining lints (dart fix --apply)
greglittlefield-wf Aug 9, 2023
a7beb88
Ignore componentZone usage warnings
greglittlefield-wf Aug 9, 2023
1a6d534
Remove unused code
greglittlefield-wf Aug 9, 2023
9949639
Fix warnings by hand
greglittlefield-wf Aug 9, 2023
5344c86
Fix comment references and links - all credit to @aaronlademann-wf
aaronlademann-wf Aug 9, 2023
e1e3f7f
Fix implicit casts, clean up variable types and `final`
greglittlefield-wf Aug 10, 2023
35297ff
Format
greglittlefield-wf Aug 11, 2023
94d3507
Remove return types on overrides so they can be inferred
greglittlefield-wf Aug 11, 2023
cf5e31a
Remove return types on overridden getters so they can be inferred
greglittlefield-wf Aug 11, 2023
b778dcd
Format
greglittlefield-wf Aug 21, 2023
920f9b1
Disable Dart 3 CI run for now
greglittlefield-wf Aug 21, 2023
60aec37
Add comment LHS-typed function declaration
greglittlefield-wf Aug 22, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
204 changes: 0 additions & 204 deletions lib/react.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2116,207 +2116,3 @@ dynamic view = validateJsApiThenReturn(() => ReactDomComponentFactoryProxy('view

/// The SVG `<vkern>` [VkernElement].
dynamic vkern = validateJsApiThenReturn(() => ReactDomComponentFactoryProxy('vkern'));

/// Create React DOM `Component`s by calling the specified [creator].
_createDOMComponents(creator) {
a = creator('a');
abbr = creator('abbr');
address = creator('address');
Comment on lines -2100 to -2104
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long has this been hanging around unused?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

area = creator('area');
article = creator('article');
aside = creator('aside');
audio = creator('audio');
b = creator('b');
base = creator('base');
bdi = creator('bdi');
bdo = creator('bdo');
big = creator('big');
blockquote = creator('blockquote');
body = creator('body');
br = creator('br');
button = creator('button');
canvas = creator('canvas');
caption = creator('caption');
cite = creator('cite');
code = creator('code');
col = creator('col');
colgroup = creator('colgroup');
data = creator('data');
datalist = creator('datalist');
dd = creator('dd');
del = creator('del');
details = creator('details');
dfn = creator('dfn');
dialog = creator('dialog');
div = creator('div');
dl = creator('dl');
dt = creator('dt');
em = creator('em');
embed = creator('embed');
fieldset = creator('fieldset');
figcaption = creator('figcaption');
figure = creator('figure');
footer = creator('footer');
form = creator('form');
h1 = creator('h1');
h2 = creator('h2');
h3 = creator('h3');
h4 = creator('h4');
h5 = creator('h5');
h6 = creator('h6');
head = creator('head');
header = creator('header');
hr = creator('hr');
html = creator('html');
i = creator('i');
iframe = creator('iframe');
img = creator('img');
input = creator('input');
ins = creator('ins');
kbd = creator('kbd');
keygen = creator('keygen');
label = creator('label');
legend = creator('legend');
li = creator('li');
link = creator('link');
main = creator('main');
map = creator('map');
mark = creator('mark');
menu = creator('menu');
menuitem = creator('menuitem');
meta = creator('meta');
meter = creator('meter');
nav = creator('nav');
noscript = creator('noscript');
object = creator('object');
ol = creator('ol');
optgroup = creator('optgroup');
option = creator('option');
output = creator('output');
p = creator('p');
param = creator('param');
picture = creator('picture');
pre = creator('pre');
progress = creator('progress');
q = creator('q');
rp = creator('rp');
rt = creator('rt');
ruby = creator('ruby');
s = creator('s');
samp = creator('samp');
script = creator('script');
section = creator('section');
select = creator('select');
small = creator('small');
source = creator('source');
span = creator('span');
strong = creator('strong');
style = creator('style');
sub = creator('sub');
summary = creator('summary');
sup = creator('sup');
table = creator('table');
tbody = creator('tbody');
td = creator('td');
textarea = creator('textarea');
tfoot = creator('tfoot');
th = creator('th');
thead = creator('thead');
time = creator('time');
title = creator('title');
tr = creator('tr');
track = creator('track');
u = creator('u');
ul = creator('ul');
variable = creator('var');
video = creator('video');
wbr = creator('wbr');

// SVG Elements
altGlyph = creator('altGlyph');
altGlyphDef = creator('altGlyphDef');
altGlyphItem = creator('altGlyphItem');
animate = creator('animate');
animateColor = creator('animateColor');
animateMotion = creator('animateMotion');
animateTransform = creator('animateTransform');
circle = creator('circle');
clipPath = creator('clipPath');
colorProfile = creator('color-profile');
cursor = creator('cursor');
defs = creator('defs');
desc = creator('desc');
discard = creator('discard');
ellipse = creator('ellipse');
feBlend = creator('feBlend');
feColorMatrix = creator('feColorMatrix');
feComponentTransfer = creator('feComponentTransfer');
feComposite = creator('feComposite');
feConvolveMatrix = creator('feConvolveMatrix');
feDiffuseLighting = creator('feDiffuseLighting');
feDisplacementMap = creator('feDisplacementMap');
feDistantLight = creator('feDistantLight');
feDropShadow = creator('feDropShadow');
feFlood = creator('feFlood');
feFuncA = creator('feFuncA');
feFuncB = creator('feFuncB');
feFuncG = creator('feFuncG');
feFuncR = creator('feFuncR');
feGaussianBlur = creator('feGaussianBlur');
feImage = creator('feImage');
feMerge = creator('feMerge');
feMergeNode = creator('feMergeNode');
feMorphology = creator('feMorphology');
feOffset = creator('feOffset');
fePointLight = creator('fePointLight');
feSpecularLighting = creator('feSpecularLighting');
feSpotLight = creator('feSpotLight');
feTile = creator('feTile');
feTurbulence = creator('feTurbulence');
filter = creator('filter');
font = creator('font');
fontFace = creator('font-face');
fontFaceFormat = creator('font-face-format');
fontFaceName = creator('font-face-name');
fontFaceSrc = creator('font-face-src');
fontFaceUri = creator('font-face-uri');
foreignObject = creator('foreignObject');
g = creator('g');
glyph = creator('glyph');
glyphRef = creator('glyphRef');
hatch = creator('hatch');
hatchpath = creator('hatchpath');
hkern = creator('hkern');
image = creator('image');
line = creator('line');
linearGradient = creator('linearGradient');
marker = creator('marker');
mask = creator('mask');
mesh = creator('mesh');
meshgradient = creator('meshgradient');
meshpatch = creator('meshpatch');
meshrow = creator('meshrow');
metadata = creator('metadata');
missingGlyph = creator('missing-glyph');
mpath = creator('mpath');
path = creator('path');
pattern = creator('pattern');
polygon = creator('polygon');
polyline = creator('polyline');
radialGradient = creator('radialGradient');
rect = creator('rect');
svgSet = creator('set');
solidcolor = creator('solidcolor');
stop = creator('stop');
svg = creator('svg');
svgSwitch = creator('switch');
symbol = creator('symbol');
text = creator('text');
textPath = creator('textPath');
tref = creator('tref');
tspan = creator('tspan');
unknown = creator('unknown');
use = creator('use');
view = creator('view');
vkern = creator('vkern');
}
1 change: 0 additions & 1 deletion lib/react_client/js_backed_map.dart
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@ JsMap jsBackingMapOrJsCopy(Map map) {
abstract class _Object {
external static void assign(JsMap to, JsMap from);
external static List<dynamic> keys(JsMap object);
external static List<dynamic> values(JsMap object);
}

@JS('Reflect')
Expand Down