-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FED-1569 Prepare for null safety: fix lints and implicit casts #366
Merged
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
e452d16
Upgrade lints to workiva_analysis_options v2.recommended
greglittlefield-wf 1446d0b
dart fix --apply --code=unnecessary_new
greglittlefield-wf 1e322c2
dart fix --apply --code=unnecessary_const
greglittlefield-wf acc03f1
dart fix --apply --code=prefer_single_quotes
greglittlefield-wf 5d2793d
dart fix --apply --code=deprecated_colon_for_default_value
greglittlefield-wf d19f23d
dart fix --apply --code=annotate_overrides
greglittlefield-wf bcad3b1
dart fix --apply --code=prefer_final_in_for_each
greglittlefield-wf 8d1a829
dart fix --apply --code=omit_local_variable_types,prefer_final_locals
greglittlefield-wf 46a38d2
Fix missing inferred generics
greglittlefield-wf 17b30cc
dart fix --apply --code=use_function_type_syntax_for_parameters,pref…
greglittlefield-wf b79d3eb
Fix more typedefs
greglittlefield-wf 6490a9c
dart fix --apply --code=unnecessary_this
greglittlefield-wf 1b5f972
dart fix --apply --code=unnecessary_brace_in_string_interps
greglittlefield-wf 2948941
dart fix --apply --code=unnecessary_parenthesis
greglittlefield-wf 911c914
Disable some more lints
greglittlefield-wf 70429ac
Remove some unnecessary function parameter types, link to linter issue
greglittlefield-wf ae1914e
Ignore lints that could change behavior or break public API if fixed
greglittlefield-wf 8b83f89
dart fix --apply --code=unused_import
greglittlefield-wf ae87897
dart fix --apply --code=unnecessary_import
greglittlefield-wf 82c5d9e
Fix miscellaneous remaining lints (dart fix --apply)
greglittlefield-wf a7beb88
Ignore componentZone usage warnings
greglittlefield-wf 1a6d534
Remove unused code
greglittlefield-wf 9949639
Fix warnings by hand
greglittlefield-wf 5344c86
Fix comment references and links - all credit to @aaronlademann-wf
aaronlademann-wf e1e3f7f
Fix implicit casts, clean up variable types and `final`
greglittlefield-wf 35297ff
Format
greglittlefield-wf 94d3507
Remove return types on overrides so they can be inferred
greglittlefield-wf cf5e31a
Remove return types on overridden getters so they can be inferred
greglittlefield-wf b778dcd
Format
greglittlefield-wf 920f9b1
Disable Dart 3 CI run for now
greglittlefield-wf 60aec37
Add comment LHS-typed function declaration
greglittlefield-wf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How long has this been hanging around unused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like almost 3 years 💀 1ef1196#diff-971a483a502cde928eaed632c11bd797a2a1e6c112fb9152dbe374291d7c8dbaL2804