tweak(gameserver): Don't enforce sessionmanager with OneSync #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This disables the forced start of the 'sessionmanager' resource when OneSync is enabled and the game type is GTA V.
| @@ -1370,19 +1370,4 @@ static InitFunction initFunction([]() | |||
| instance->SetComponent(new fx::PeerAddressRateLimiterStore(instance->GetComponent<console::Context>().GetRef())); | |||
| instance->SetComponent(new HostVoteCount()); | |||
| }); | |||
|
|
|||
| fx::ServerInstanceBase::OnServerCreate.Connect([](fx::ServerInstanceBase* instance) | |||
There was a problem hiding this comment.
What was the reason for the removal of the fx::ServerInstanceBase::OnServerCreate.Connect?
There was a problem hiding this comment.
Moving this to another fwEvent isn't needed for this change, but as this one was only used to start sessionmanager and all needed components have already been set in the earlier "on create" call I thought moving it there is fine. This ofc can stay in the existing event call if preferred.
github-actions
bot
added
the
invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
This disables the forced start of the 'sessionmanager' resource when OneSync is enabled and the game type is GTA V.
How is this PR achieving the goal
Unlike RDR2, GTA V does not require any logic that is implemented in the 'sessionmanager' resource when running with OneSync enabled. The Lua scheduler implementation for invoking remote function references in
fivem/data/shared/citizen/scripting/lua/scheduler.lua
Line 567 in 76e67bd
This PR applies to the following area(s)
FiveM
Successfully tested on
Game builds: Not applicable
Platforms: Windows (Server), Linux
Checklist
Fixes issues
Resolves #2876