Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version #10639

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Update node version #10639

merged 1 commit into from
Apr 15, 2023

Conversation

inductor
Copy link
Contributor

@inductor inductor commented Apr 15, 2023

What

  • Update node version
  • Use .node-version to set up CI

Why

There's a newer version that includes numbers of CVE fixes. Ref: https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#2023-02-16-version-18141-hydrogen-lts-rafaelgss-prepared-by-juanarbol

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot requested review from syuilo and tamaina April 15, 2023 01:19
@@ -1 +1 @@
v18.13.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This v is not necessary

@syuilo syuilo merged commit 5a8748b into misskey-dev:develop Apr 15, 2023
@syuilo
Copy link
Member

syuilo commented Apr 15, 2023

👍

@inductor inductor deleted the update_node branch April 15, 2023 01:21
@tamaina
Copy link
Contributor

tamaina commented Apr 15, 2023

バージョンあげたらCypressが落ちるようになった…?

#10644

na2na-p pushed a commit to na2na-p/misskey that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants